// Copyright (c) 2017-2022 Cloudflare, Inc. // Licensed under the Apache 2.0 license found in the LICENSE file or at: // https://opensource.org/licenses/Apache-2.0 #include "jsg-test.h" #include namespace workerd::jsg::test { namespace { V8System v8System; class ContextGlobalObject: public Object, public ContextGlobal {}; struct BoxContext: public ContextGlobalObject { JSG_RESOURCE_TYPE(BoxContext) { JSG_NESTED_TYPE(NumberBox); JSG_NESTED_TYPE(BoxBox); } }; JSG_DECLARE_ISOLATE_TYPE(BoxIsolate, BoxContext, NumberBox, BoxBox); KJ_TEST("constructors and properties") { Evaluator e(v8System); e.expectEval("new NumberBox(123).value", "number", "123"); e.expectEval("new NumberBox(123).boxed.value", "number", "123"); e.expectEval("new BoxBox(new NumberBox(123), 321).inner.value", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.value = 321;\n" "n.getValue()", "number", "321"); e.expectEval("var n = new NumberBox(123);\n" "n.boxed = new NumberBox(321);\n" "n.getValue()", "number", "321"); e.expectEval("new NumberBox(123) instanceof NumberBox", "boolean", "true"); e.expectEval("new NumberBox(123) instanceof BoxBox", "boolean", "false"); } KJ_TEST("methods") { Evaluator e(v8System); e.expectEval("var n = new NumberBox(123);\n" "n.increment();\n" "n.getValue()", "number", "124"); e.expectEval("var n = new NumberBox(123);\n" "n.incrementBy(321);\n" "n.getValue()", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.incrementByBox(new NumberBox(321));\n" "n.getValue()", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.add(321)", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.addBox(new NumberBox(321))", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.addReturnBox(321).value", "number", "444"); e.expectEval("var n = new NumberBox(123);\n" "n.addMultiple(new NumberBox(321), 111, new NumberBox(2222))", "number", "2777"); e.expectEval("var n = new NumberBox(123);\n" "new n.increment();", "throws", "TypeError: n.increment is not a constructor"); } // ======================================================================================== struct Mixin { int getValue() { return i; } Mixin(int i): i(i) {} int i; }; struct InheritsMixin: public Object, public Mixin { InheritsMixin(int i): Mixin(i) {} JSG_RESOURCE_TYPE(InheritsMixin) { JSG_METHOD(getValue); } }; struct InheritsMixinContext: public ContextGlobalObject { Ref makeInheritsMixin(jsg::Lock& js, int i) { return js.alloc(i); } JSG_RESOURCE_TYPE(InheritsMixinContext) { JSG_METHOD(makeInheritsMixin); } }; JSG_DECLARE_ISOLATE_TYPE(InheritsMixinIsolate, InheritsMixinContext, InheritsMixin); KJ_TEST("JSG_METHODs can be implemented by mixins") { Evaluator e(v8System); e.expectEval("makeInheritsMixin(12345).getValue()", "number", "12345"); } // ======================================================================================== struct PrototypePropertyObject: public Object { double value; PrototypePropertyObject(double value): value(value) {} static Ref constructor(jsg::Lock& js, double value) { return js.alloc(value); } double getValue() { return value; } void setValue(double v) { value = v; } JSG_RESOURCE_TYPE(PrototypePropertyObject) { JSG_PROTOTYPE_PROPERTY(value, getValue, setValue); } }; struct PropContext: public ContextGlobalObject { PropContext(): contextProperty(kj::str("default-context-property-value")) {} kj::StringPtr getContextProperty() { return contextProperty; } void setContextProperty(kj::String s) { contextProperty = kj::mv(s); } JSG_RESOURCE_TYPE(PropContext) { JSG_METHOD(getContextProperty); JSG_METHOD(setContextProperty); JSG_INSTANCE_PROPERTY(contextProperty, getContextProperty, setContextProperty); JSG_NESTED_TYPE(PrototypePropertyObject); } private: kj::String contextProperty; }; JSG_DECLARE_ISOLATE_TYPE(PropIsolate, PropContext, PrototypePropertyObject); const auto kIllegalInvocation = "TypeError: Illegal invocation: function called with incorrect `this` reference. " "See https://developers.cloudflare.com/workers/observability/errors/#illegal-invocation-errors for details."_kj; KJ_TEST("context methods and properties") { Evaluator e(v8System); e.expectEval("getContextProperty()", "string", "default-context-property-value"); e.expectEval("setContextProperty('foo');\n" "getContextProperty()", "string", "foo"); e.expectEval("contextProperty", "string", "default-context-property-value"); e.expectEval("contextProperty = 'foo'; getContextProperty()", "string", "foo"); e.expectEval("this.getContextProperty()", "string", "default-context-property-value"); e.expectEval("this.setContextProperty('foo');\n" "getContextProperty()", "string", "foo"); e.expectEval("this.contextProperty", "string", "default-context-property-value"); e.expectEval("this.contextProperty = 'foo'; getContextProperty()", "string", "foo"); e.expectEval("let p = new PrototypePropertyObject(123);\n" "let o = {};\n" "o.__proto__ = p.__proto__;\n" "o.value", "throws", kIllegalInvocation); e.expectEval("let p = new PrototypePropertyObject(123);\n" "let o = {};\n" "o.__proto__ = p.__proto__;\n" "o.value = 123", "throws", kIllegalInvocation); e.expectEval("class P2 extends PrototypePropertyObject {\n" " constructor(v) { super(v); }\n" "}\n" "let p = new P2(123);\n" "p.value", "number", "123"); } // ======================================================================================== struct NonConstructibleContext: public ContextGlobalObject { struct NonConstructible: public Object { NonConstructible(double x): x(x) {} double x; double method() { return x; } JSG_RESOURCE_TYPE(NonConstructible) { JSG_METHOD(method); } }; Ref getNonConstructible(jsg::Lock& js, double x) { return js.alloc(x); } JSG_RESOURCE_TYPE(NonConstructibleContext) { JSG_NESTED_TYPE(NonConstructible); JSG_METHOD(getNonConstructible); } }; JSG_DECLARE_ISOLATE_TYPE( NonConstructibleIsolate, NonConstructibleContext, NonConstructibleContext::NonConstructible); KJ_TEST("non-constructible types can't be constructed") { Evaluator e(v8System); e.expectEval("new NonConstructible().method()", "throws", "TypeError: Illegal constructor"); e.expectEval("getNonConstructible(12321).method()", "number", "12321"); e.expectEval("getNonConstructible(12321) instanceof NonConstructible", "boolean", "true"); } // ======================================================================================== struct IterableContext: public ContextGlobalObject { class Iterable: public Object { public: static Ref constructor(jsg::Lock& js) { return js.alloc(); } class Iterator: public Object { public: struct NextValue { bool done; Optional value; JSG_STRUCT(done, value); }; explicit Iterator(Ref parentParam) : parent(kj::mv(parentParam)), cursor(parent->values) {} NextValue next() { if (cursor == parent->values + sizeof(parent->values) / sizeof(*parent->values)) { return {.done = true, .value = kj::none}; } return {.done = false, .value = *cursor++}; } v8::Local self(const v8::FunctionCallbackInfo& info) { // Helper to make this iterator itself iterable. This allows code like // `for (let k of iterable.entries())` to work. return info.This(); } JSG_RESOURCE_TYPE(Iterator) { JSG_INHERIT_INTRINSIC(v8::kIteratorPrototype); JSG_METHOD(next); JSG_ITERABLE(self); } private: Ref parent; int* cursor; }; Ref entries(const v8::FunctionCallbackInfo& info) { auto& js = jsg::Lock::from(info.GetIsolate()); return js.alloc(JSG_THIS); } JSG_RESOURCE_TYPE(Iterable) { JSG_METHOD(entries); JSG_ITERABLE(entries); } private: int values[10] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9}; // In real code, this data structure could be more complex, and we would need to think about // iterator invalidation, which might require storing back-references from the parent iterable // to all of its live iterators to make sure they can be nulled out if necessary. But then we // need to worry about circular references ... }; JSG_RESOURCE_TYPE(IterableContext) { JSG_NESTED_TYPE(Iterable); } }; JSG_DECLARE_ISOLATE_TYPE(IterableIsolate, IterableContext, IterableContext::Iterable, IterableContext::Iterable::Iterator, IterableContext::Iterable::Iterator::NextValue); KJ_TEST("Iterables can be iterated") { Evaluator e(v8System); e.expectEval("let results = [];" "for (let n of new Iterable()) { results.push(n); };" "'' + results.join('')", "string", "0123456789"); e.expectEval("let results = [];" "for (let n of new Iterable().entries()) { results.push(n); };" "'' + results.join('')", "string", "0123456789"); e.expectEval( "let arrayIterator = [][Symbol.iterator]();" "let arrayIteratorPrototype = Object.getPrototypeOf(Object.getPrototypeOf(arrayIterator));" "let iterator = new Iterable().entries();" "let iteratorPrototype = Object.getPrototypeOf(Object.getPrototypeOf(iterator));" "iteratorPrototype === arrayIteratorPrototype", "boolean", "true"); } // ======================================================================================== struct StaticContext: public ContextGlobalObject { struct StaticConstants: public Object { static Ref constructor(jsg::Lock& js) { return js.alloc(); } static constexpr double DOUBLE = 1.5; static constexpr int INT = 123; static constexpr bool BOOL = true; static constexpr kj::StringPtr STRING = "a static constant string"_kj; JSG_RESOURCE_TYPE(StaticConstants) { JSG_STATIC_CONSTANT(DOUBLE); JSG_STATIC_CONSTANT(INT); JSG_STATIC_CONSTANT(BOOL); JSG_STATIC_CONSTANT(STRING); } }; struct StaticMethods: public Object { static Ref constructor(jsg::Lock& js) { return js.alloc(); } static v8::Local passThrough(v8::Local arg) { return arg; } static v8::Local passThroughWithInfo( const v8::FunctionCallbackInfo& info, v8::Local arg) { return arg; } static void voidCall() {} static void voidCallWithInfo(const v8::FunctionCallbackInfo& info) {} static Unimplemented unimplementedStaticMethod() { return {}; } static void delete_() {} JSG_RESOURCE_TYPE(StaticMethods) { JSG_STATIC_METHOD(passThrough); JSG_STATIC_METHOD(passThroughWithInfo); JSG_STATIC_METHOD(voidCall); JSG_STATIC_METHOD(voidCallWithInfo); JSG_STATIC_METHOD_NAMED(delete, delete_); JSG_STATIC_METHOD(unimplementedStaticMethod); } }; struct StaticProperties: public Object { static Ref constructor(jsg::Lock& js) { return js.alloc(); } // Static property returning a simple value static int simpleValue() { return 42; } // Static property returning a string static kj::String stringValue() { return kj::str("static property string"); } // Static property returning an array static kj::Array arrayValue() { auto array = kj::heapArray(3); array[0] = 1; array[1] = 2; array[2] = 3; return kj::mv(array); } // Static property returning void (edge case) static void voidProperty() { // This should be handled gracefully even though it's unusual for a property } // A getter function to be used with JSG_STATIC_READONLY_PROPERTY_NAMED static double getComputedValue() { return 3.14159; } // Another named property getter static kj::String getDescription() { return kj::str("This is a static property"); } // Static property that takes Lock& as first parameter static int withLockValue(jsg::Lock& js) { // We can use the lock here if needed, but for testing just return a value return 99; } // Static property with Lock& that returns an allocated object static kj::String withLockString(jsg::Lock& js) { return kj::str("property with lock"); } JSG_RESOURCE_TYPE(StaticProperties) { JSG_STATIC_READONLY_PROPERTY(simpleValue); JSG_STATIC_READONLY_PROPERTY(stringValue); JSG_STATIC_READONLY_PROPERTY(arrayValue); JSG_STATIC_READONLY_PROPERTY(voidProperty); JSG_STATIC_READONLY_PROPERTY_NAMED(computedValue, getComputedValue); JSG_STATIC_READONLY_PROPERTY_NAMED(description, getDescription); JSG_STATIC_READONLY_PROPERTY(withLockValue); JSG_STATIC_READONLY_PROPERTY(withLockString); } }; JSG_RESOURCE_TYPE(StaticContext) { JSG_NESTED_TYPE(StaticConstants); JSG_NESTED_TYPE(StaticMethods); JSG_NESTED_TYPE(StaticProperties); } }; JSG_DECLARE_ISOLATE_TYPE(StaticIsolate, StaticContext, StaticContext::StaticConstants, StaticContext::StaticMethods, StaticContext::StaticProperties); KJ_TEST("Static constants are exposed as constructor properties") { Evaluator e(v8System); e.expectEval("StaticConstants.DOUBLE === 1.5", "boolean", "true"); e.expectEval("StaticConstants.INT === 123", "boolean", "true"); e.expectEval("StaticConstants.BOOL === true", "boolean", "true"); e.expectEval("StaticConstants.STRING === 'a static constant string'", "boolean", "true"); } KJ_TEST("Static constants are exposed as constructor prototype properties") { Evaluator e(v8System); e.expectEval("StaticConstants.prototype.DOUBLE === 1.5", "boolean", "true"); e.expectEval("StaticConstants.prototype.INT === 123", "boolean", "true"); e.expectEval("StaticConstants.prototype.BOOL === true", "boolean", "true"); e.expectEval( "StaticConstants.prototype.STRING === 'a static constant string'", "boolean", "true"); } KJ_TEST("Static constants are exposed as object instance properties") { Evaluator e(v8System); e.expectEval("new StaticConstants().DOUBLE === 1.5", "boolean", "true"); e.expectEval("new StaticConstants().INT === 123", "boolean", "true"); e.expectEval("new StaticConstants().BOOL === true", "boolean", "true"); e.expectEval("new StaticConstants().STRING === 'a static constant string'", "boolean", "true"); } KJ_TEST("Static constants are exposed as object instance prototype properties") { Evaluator e(v8System); e.expectEval("Object.getPrototypeOf(new StaticConstants()).DOUBLE === 1.5", "boolean", "true"); e.expectEval("Object.getPrototypeOf(new StaticConstants()).INT === 123", "boolean", "true"); e.expectEval("Object.getPrototypeOf(new StaticConstants()).BOOL === true", "boolean", "true"); e.expectEval("Object.getPrototypeOf(new StaticConstants()).STRING === 'a static constant string'", "boolean", "true"); } KJ_TEST("Static methods are exposed as constructor properties") { Evaluator e(v8System); e.expectEval("StaticMethods.passThrough(true)", "boolean", "true"); e.expectEval("StaticMethods.passThroughWithInfo(true)", "boolean", "true"); e.expectEval("StaticMethods.voidCall(); true;", "boolean", "true"); e.expectEval("StaticMethods.voidCallWithInfo(); true;", "boolean", "true"); e.expectEval("StaticMethods.delete(); true;", "boolean", "true"); e.expectEval("StaticMethods.unimplementedStaticMethod()", "throws", "Error: Failed to execute 'unimplementedStaticMethod' on 'StaticMethods': " "the method is not implemented."); e.expectEval("new StaticMethods.passThrough(true);", "throws", "TypeError: StaticMethods.passThrough is not a constructor"); } KJ_TEST("Static methods are not exposed as constructor prototype properties") { Evaluator e(v8System); e.expectEval("typeof StaticMethods.prototype.passThrough === 'undefined'\n" "&& typeof StaticMethods.prototype.passThroughWithInfo === 'undefined'\n" "&& typeof StaticMethods.prototype.voidCall === 'undefined'\n" "&& typeof StaticMethods.prototype.voidCallWithInfo === 'undefined'\n" "&& typeof StaticMethods.prototype.delete === 'undefined'\n" "&& typeof StaticMethods.prototype.unimplementedStaticMethod === 'undefined'", "boolean", "true"); } KJ_TEST("Static methods are not exposed as object instance properties") { Evaluator e(v8System); e.expectEval("let obj = new StaticMethods();\n" "typeof obj.passThrough === 'undefined'\n" "&& typeof obj.passThroughWithInfo === 'undefined'\n" "&& typeof obj.voidCall === 'undefined'\n" "&& typeof obj.voidCallWithInfo === 'undefined'\n" "&& typeof obj.delete === 'undefined'\n" "&& typeof obj.unimplementedStaticMethod === 'undefined'", "boolean", "true"); } KJ_TEST("Static properties are exposed as constructor properties") { Evaluator e(v8System); // Test simple value property e.expectEval("StaticProperties.simpleValue", "number", "42"); e.expectEval("StaticProperties.simpleValue === 42", "boolean", "true"); // Test string property e.expectEval("StaticProperties.stringValue", "string", "static property string"); e.expectEval("StaticProperties.stringValue === 'static property string'", "boolean", "true"); // Test array property e.expectEval("Array.isArray(StaticProperties.arrayValue)", "boolean", "true"); e.expectEval("StaticProperties.arrayValue.length", "number", "3"); e.expectEval("StaticProperties.arrayValue[0]", "number", "1"); e.expectEval("StaticProperties.arrayValue[1]", "number", "2"); e.expectEval("StaticProperties.arrayValue[2]", "number", "3"); // Test void property (should be undefined) e.expectEval("StaticProperties.voidProperty", "undefined", "undefined"); // Test named properties e.expectEval("StaticProperties.computedValue", "number", "3.14159"); e.expectEval("StaticProperties.description", "string", "This is a static property"); // Test properties that take Lock& as first parameter e.expectEval("StaticProperties.withLockValue", "number", "99"); e.expectEval("StaticProperties.withLockString", "string", "property with lock"); } KJ_TEST("Static properties are read-only") { Evaluator e(v8System); // Attempting to write to static properties should have no effect e.expectEval("StaticProperties.simpleValue = 100; StaticProperties.simpleValue", "number", "42"); e.expectEval("StaticProperties.stringValue = 'new'; StaticProperties.stringValue", "string", "static property string"); e.expectEval( "StaticProperties.computedValue = 0; StaticProperties.computedValue", "number", "3.14159"); e.expectEval( "StaticProperties.withLockValue = 200; StaticProperties.withLockValue", "number", "99"); } KJ_TEST("Static properties are not functions") { Evaluator e(v8System); // Static properties should not be callable as functions e.expectEval("typeof StaticProperties.simpleValue", "string", "number"); e.expectEval("StaticProperties.simpleValue()", "throws", "TypeError: StaticProperties.simpleValue is not a function"); e.expectEval("new StaticProperties.simpleValue()", "throws", "TypeError: StaticProperties.simpleValue is not a constructor"); } KJ_TEST("Static properties are not exposed as instance properties") { Evaluator e(v8System); e.expectEval("let obj = new StaticProperties();\n" "typeof obj.simpleValue === 'undefined'\n" "&& typeof obj.stringValue === 'undefined'\n" "&& typeof obj.arrayValue === 'undefined'\n" "&& typeof obj.voidProperty === 'undefined'\n" "&& typeof obj.computedValue === 'undefined'\n" "&& typeof obj.description === 'undefined'\n" "&& typeof obj.withLockValue === 'undefined'\n" "&& typeof obj.withLockString === 'undefined'", "boolean", "true"); } KJ_TEST("Static properties are not exposed on prototype") { Evaluator e(v8System); e.expectEval("typeof StaticProperties.prototype.simpleValue === 'undefined'\n" "&& typeof StaticProperties.prototype.stringValue === 'undefined'\n" "&& typeof StaticProperties.prototype.arrayValue === 'undefined'\n" "&& typeof StaticProperties.prototype.voidProperty === 'undefined'\n" "&& typeof StaticProperties.prototype.computedValue === 'undefined'\n" "&& typeof StaticProperties.prototype.description === 'undefined'\n" "&& typeof StaticProperties.prototype.withLockValue === 'undefined'\n" "&& typeof StaticProperties.prototype.withLockString === 'undefined'", "boolean", "true"); } KJ_TEST("Static methods are not exposed as object instance prototype properties") { Evaluator e(v8System); e.expectEval("let objProto = Object.getPrototypeOf(new StaticMethods());\n" "typeof objProto.passThrough === 'undefined'\n" "&& typeof objProto.passThroughWithInfo === 'undefined'\n" "&& typeof objProto.voidCall === 'undefined'\n" "&& typeof objProto.voidCallWithInfo === 'undefined'\n" "&& typeof objProto.delete === 'undefined'\n" "&& typeof objProto.unimplementedStaticMethod === 'undefined'", "boolean", "true"); } KJ_TEST("Static methods can be monkey-patched") { Evaluator e(v8System); e.expectEval("StaticMethods.passThrough = function(a) { return false; };\n" "StaticMethods.passThrough(true)", "boolean", "false"); } // ======================================================================================== struct ReflectionContext: public ContextGlobalObject { struct Super: public Object { JSG_RESOURCE_TYPE(Super) {} }; struct Reflector: public Super { static jsg::Ref constructor(jsg::Lock& js) { auto result = js.alloc(); // Check reflection returns null when wrapper isn't allocated. KJ_EXPECT(result->intReflector.get(js.v8Isolate, "foo") == kj::none); KJ_EXPECT(result->stringReflector.get(js.v8Isolate, "foo") == kj::none); return result; } kj::Maybe getIntReflection(jsg::Lock& js, kj::String name) { return intReflector.get(js.v8Isolate, name); } kj::Maybe getStringReflection(jsg::Lock& js, kj::String name) { return stringReflector.get(js.v8Isolate, name); } PropertyReflection intReflector; PropertyReflection stringReflector; JSG_RESOURCE_TYPE(Reflector) { JSG_INHERIT(Super); JSG_METHOD(getIntReflection); JSG_METHOD(getStringReflection); } JSG_REFLECTION(intReflector, stringReflector); }; jsg::Ref makeReflector(jsg::Lock& js) { return js.alloc(); } jsg::Ref makeSuper(jsg::Lock& js) { return js.alloc(); } JSG_RESOURCE_TYPE(ReflectionContext) { JSG_NESTED_TYPE(Reflector); JSG_METHOD(makeReflector); JSG_METHOD(makeSuper); } }; JSG_DECLARE_ISOLATE_TYPE( ReflectionIsolate, ReflectionContext, ReflectionContext::Super, ReflectionContext::Reflector); KJ_TEST("PropertyReflection works") { Evaluator e(v8System); e.expectEval("let r = new Reflector; r.getIntReflection('foo')", "object", "null"); e.expectEval("let r = new Reflector; r.foo = 123; r.getIntReflection('foo')", "number", "123"); e.expectEval("let r = new Reflector; r.foo = 123; r.getStringReflection('foo')", "string", "123"); e.expectEval("let r = makeReflector(); r.foo = 123; r.getIntReflection('foo')", "number", "123"); e.expectEval("let r = makeSuper(); r.foo = 123; r.getIntReflection('foo')", "number", "123"); } // ======================================================================================== struct InjectLockContext: public ContextGlobalObject { struct Thingy: public Object { Thingy(int val, v8::Isolate* v8Isolate): val(val), v8Isolate(v8Isolate) {} int val; v8::Isolate* v8Isolate; static Ref constructor(Lock& js, int val) { return js.alloc(val, js.v8Isolate); } int frob(Lock& js, int val2) { KJ_ASSERT(js.v8Isolate == v8Isolate); return val + val2; } int getVal(Lock& js) { KJ_ASSERT(js.v8Isolate == v8Isolate); return val; } void setVal(Lock& js, int val) { KJ_ASSERT(js.v8Isolate == v8Isolate); this->val = val; } static int borf(Lock& js, int val) { return val * 2; } JSG_RESOURCE_TYPE(Thingy) { JSG_METHOD(frob); JSG_PROTOTYPE_PROPERTY(val, getVal, setVal); JSG_STATIC_METHOD(borf); } }; JSG_RESOURCE_TYPE(InjectLockContext) { JSG_NESTED_TYPE(Thingy); } }; JSG_DECLARE_ISOLATE_TYPE(InjectLockIsolate, InjectLockContext, InjectLockContext::Thingy); KJ_TEST("Methods can take Lock& as first parameter") { Evaluator e(v8System); e.expectEval("let t = new Thingy(123); t.val", "number", "123"); } // ======================================================================================== struct JsBundleContext: public ContextGlobalObject { JSG_RESOURCE_TYPE(JsBundleContext) { JSG_CONTEXT_JS_BUNDLE(BUILTIN_BUNDLE); } }; JSG_DECLARE_ISOLATE_TYPE(JsBundleIsolate, JsBundleContext); KJ_TEST("expectEvalModule function works") { Evaluator e( v8System); e.expectEvalModule("export function run() { return 123; }", "number", "123"); } KJ_TEST("bundle installed works") { Evaluator e( v8System); e.expectEvalModule(R"( import * as b from "test:resource-test-builtin"; export function run() { return b.builtinFunction(); } )", "string", "THIS_IS_BUILTIN_FUNCTION"); } // ======================================================================================== // Regression test for https://github.com/cloudflare/workerd/issues/4147 struct InspectableObject: public Object { double value; explicit InspectableObject(double value): value(value) {} static Ref constructor(jsg::Lock& js, double value) { return js.alloc(value); } double getValue() { return value; } kj::String inspectState() { return kj::str("active"); } JSG_RESOURCE_TYPE(InspectableObject) { JSG_METHOD(getValue); JSG_READONLY_PROTOTYPE_PROPERTY(value, getValue); JSG_INSPECT_PROPERTY(state, inspectState); } }; struct InspectContext: public ContextGlobalObject { JSG_RESOURCE_TYPE(InspectContext) { JSG_NESTED_TYPE(InspectableObject); } }; JSG_DECLARE_ISOLATE_TYPE(InspectIsolate, InspectContext, InspectableObject); KJ_TEST("Object.getOwnPropertyDescriptors does not throw on prototype with inspect properties") { Evaluator e(v8System); // The core regression: getOwnPropertyDescriptors must not throw. e.expectEval("JSON.stringify(typeof Object.getOwnPropertyDescriptors(" " InspectableObject.prototype))", "string", "\"object\""); // Methods should appear as data descriptors. e.expectEval("typeof Object.getOwnPropertyDescriptors(" " InspectableObject.prototype).getValue.value", "string", "function"); // The prototype property 'value' should appear as an accessor descriptor. e.expectEval("typeof Object.getOwnPropertyDescriptors(" " InspectableObject.prototype).value.get", "string", "function"); // Instances should also tolerate getOwnPropertyDescriptors. e.expectEval("JSON.stringify(typeof Object.getOwnPropertyDescriptors(" " new InspectableObject(42)))", "string", "\"object\""); } // ======================================================================================== } // namespace } // namespace workerd::jsg::test