Skip to content
Commit Detail

Commit e1e2424

Author
Jeremy Morrell (Cloudflare) <jmorrell@cloudflare.com> 2025-09-19 16:21:47 -0700
Parents
481badb, 49ea8e1
Tree
0dbd41d
Merge pull request #5120 from cloudflare/jmorrell/kv-attribute-refinement

While trying to document the KV attributes I ran into some inconsistencies and some missing bits. Here I try to bring them all together.

kv_get vs kv_get_bulk is an internal detail. The method the user is calling is always kv.get, so let's have the name match the user interface.
cloudflare.kv.query.keys vs cloudflare.kv.query.key is also a bit annoying. Consolidate on cloudflare.kv.query.keys always, and make sure it's present in every get and getWithMetadata path.
added a cloudflare.kv.query.keys.count
The previous code incorrectly converted the array of keys to a string. This uses kj::strArray to do it correctly. It also cuts it off as 512 characters to prevent massive attribute values. Let me know if you think this isn't necessary or should have a different default.
added cloudflare.kv.response.size and cloudflare.kv.response.returned_rows to every method that returns a response
db.system -> db.system.name to match semantic conventions
cloudflare.binding.name and cloudflare.binding.type to match R2
removed db.namespace

Files changed

2 files changed~2 modified
Compared against first parent