Skip to content
Commit Detail

Commit acf27e6

Author
Harris Hancock <harris@cloudflare.com> 2024-06-17 14:02:48 +0100
Parents
8bdf32f
Tree
49e3ab6
Update V8 12.6 -> 12.7

V8 update from 12.6.228.7 -> 12.7.224.12.

I noticed that V8 tests did not pass for either the current or new version of V8, and saw that our v8::Locker patch was to blame. I initially modified it to work, by exiting and re-entering in v8::Unlocker, but then decided to try just removing the patch entirely. All tests pass with it removed, so let's try. Removing the patch required adding a couple Isolate::Scopes in our code that were previously implicit.

V8 12.7 also ships with the AsyncDispose symbol, so I removed our polyfill.

Lastly, V8 now provides a SetFatalErrorHandler() function, which I call with our DCHECK-handling function. This will allow us to drop a separate patch from our internal repo.

Files changed

34 files changed+11 added~11 modified-12 deleted