Skip to content
Commit Detail

Commit a973d2a

Author
Kenton Varda <kenton@cloudflare.com> 2025-01-20 12:13:57 -0600
Parents
029973c
Tree
93d56ec
Fix rare scenario where outgoing WebSocket messages could be dropped.

Per the comment: At the end of pump(), while writing out pending auto-response messages, it's possible new regular messages could be queued concurrently. If we don't check for that, they could be discarded without actually being sent.

This is probably extremely unlikely and I have no evidence that it has ever happened. I noticed the problem while reading the code.

Files changed

1 file changed~1 modified