Author

Jon Phillips <jphillips@cloudflare.com> 2024-10-30 14:21:18 +0000

Parents

c3b0c07

Tree

1d55bc6

Fix handling of termination exceptions.

Exceptions caught in v8::TryCatch scopes need to be rethrown in order
for the next try/catch handler down the stack to be notified of them. In
some code paths, we rethrow the native jsg::JsExceptionThrown exception
but don't rethrow the v8 exception using v8::TryCatch::ReThrow().

This commit fixes one such code path which resulted in
IoContext::runImpl's jsg::JsExceptionThrown's catch block finding that
the corresponding v8::TryCatch object hadn't been notified of the
termination (and didn't contain an exception).