Skip to content
Commit Detail

Commit 268dd00

Author
Kenton Varda <kenton@cloudflare.com> 2024-09-20 18:02:17 -0500
Parents
94fe62e
Tree
bc4573a
JSRPC: Fix bug where RPCs returning plain objects still required disposal.

If an RPC returns a plain object (with no stubs and no disposer), then it should not be necessary to call its disposer on the caller side.

I had explicitly accounted for this in the protocol, but forgot to handle it correctly in the code! So the callee context would be held open until the caller disposed the result. If the caller didn't do that, the callee would be held open until the caller context ended.

Files changed

2 files changed~2 modified