Skip to content
Commit Detail

Commit 1eb2e0b

Author
Kenton Varda <kenton@cloudflare.com> 2024-06-21 16:25:47 -0500
Parents
b1b9d93
Tree
7fcbab8
Wrap usage of GetIdentityHash() in kj::hashCode().

This may or may not be necessary in conjunction with the KJ hashCode() change: https://github.com/capnproto/capnproto/pull/2086

I couldn't figure out if V8's `GetIdentityHash()` returns uniform hashes vs., say, addresses. It looks like in at least some cases they are uniform, but it's really hard to _find_ all the V8 hash implementations in their code. Some seem to be generated by Torque?

If we just wrap these in `kj::hashCode()` then our bases should be covered, at the expense of an extra cycle or three to rehash the values.

Files changed

6 files changed~6 modified