Skip to content
Commit Detail

Commit 18ccc1f

Author
James M Snell <jasnell@gmail.com> 2024-09-25 08:19:08 -0700
Parents
de453f4
Tree
a86aa85
Add cloudflare internal symbol to resourcetypes

Miniflare has been using the lack of `Symbol.toStringTag` to detect
internal API objects. This is brittle and problematic because for
compliance with standard web platform APIs we're supposed to be adding
the Symbol.toStringTag to standard types and there are modules in the
ecosystem that depend on it. We recently landed a change that adds the
Symbol.toStringTag to types but that broke miniflare. This PR adds an
alternative symbol to jsg::Objects that can identify themselves as
internal.

Files changed

2 files changed~2 modified