Author

Milan Miladinovic <milan@cloudflare.com> 2024-04-12 15:08:33 -0400

Parents

35a6d01

Tree

b40ee9f

Reuse ActorContainerRef if it exists

Prior to this commit, if a Durable Object in Workerd (local
dev/miniflare) hibernated (i.e. Worker::Actor was destroyed),
but the stub wasn't dropped by the worker (i.e. PromisedWorkerInterface
still alive), then we would incorrectly create an entirely new refcounted
ActorContainerRef upon a new request coming in.

This is incorrect because the old ActorContainerRef is still owned, and
by creating an entirely separate one, we break our request tracking.

Specifically, the ActorContainer only tracks a weak reference to an
ActorContainerRef, and so if we have two separate ActorContainerRef's
one of them will not be tracked.