Author

Kenton Varda <kenton@cloudflare.com> 2024-12-13 09:47:56 -0600

Parents

ace145c

Tree

ed3e9ca

Undo tightening of rules around default entrypoints in #3193.

Say you have a module-syntax Worker that has no `export default`. You then refer to that worker from elsewhere in the workerd config, but you do not specify an entrypoint. What should happen?

In the midst of other changes, PR #3193 turned this into an error, becaues it seemed like obviously it should be. This turns out to have broken Miniflare tests, which often use an empty string as a placeholder Worker that is referenced but never invoked.

So, this PR restores the old behavior.

It turns out, incidentally, that the old behavior is crazier than you'd imagine. See the comments in the test case for details.