File
Blob: patches/v8/0016-Disable-memory-leak-assert-when-shutting-down-V8.patch
| 1 | From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
| 2 | From: Erik Corry <erikcorry@chromium.org> |
| 3 | Date: Thu, 5 Dec 2024 14:07:44 +0100 |
| 4 | Subject: Disable memory leak assert when shutting down V8 |
| 5 | |
| 6 | Signed-off-by: James M Snell <jsnell@cloudflare.com> |
| 7 | |
| 8 | diff --git a/src/wasm/wasm-code-pointer-table.cc b/src/wasm/wasm-code-pointer-table.cc |
| 9 | index 51a20ad8d94e271218be4b993bce7067aaa176fa..c135cd7fc66b3f3ef0c9fba801a6936d9436c846 100644 |
| 10 | --- a/src/wasm/wasm-code-pointer-table.cc |
| 11 | +++ b/src/wasm/wasm-code-pointer-table.cc |
| 12 | @@ -14,7 +14,10 @@ void WasmCodePointerTable::Initialize() { Base::Initialize(); } |
| 13 | void WasmCodePointerTable::TearDown() { |
| 14 | FreeNativeFunctionHandles(); |
| 15 | SweepSegments(0); |
| 16 | - DCHECK(freelist_head_.load().is_empty()); |
| 17 | + // This triggers for Cloudflare when shutting down V8, but that |
| 18 | + // is only something that happens in tests. TODO: Investigate |
| 19 | + // whether this is leaking in regular use. |
| 20 | + // CHECK(freelist_head_.load().is_empty()); |
| 21 | Base::TearDown(); |
| 22 | } |
| 23 |